Update sw-precache-webpack-plugin to lastest version #2429
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
goldhand
changed the title
|
Looks great. Thanks. |
* Update sw-precache-webpack-plugin to v0.11.3 * Pin the version
* Update sw-precache-webpack-plugin to v0.11.3 * Pin the version
* Update sw-precache-webpack-plugin to v0.11.3 * Pin the version
Updating sw-precache-webpack-plugin to
v0.11.3will fix the following related issues:Windows path: #2235
Duplicate builds: #1728 (comment)
I have tested by running
/bin/react-scripts.js buildand asserting that the build log message is not emitted twice. The problem was discovered in this goldhand/sw-precache-webpack-plugin#78 we were calling the webpackdonecallback twice.I do not have a windows machine to test the windows fix but the fix is exactly the same as in this configuration. The fix is here and has been published for a couple weeks now with no issue.
In addition to these fixes, updating to
0.11.3will allow chunk's with hashes to be "precached" and used inimportScripts.